Add rocBLAS yaml files for gfx1151#699
Merged
amcamd merged 4 commits intoJul 17, 2025
Merged
Conversation
amd-mtrifuno
requested review from
NaveenElumalaiAMD,
TorreZuk,
amcamd,
babakpst,
bragadeesh,
daineAMD,
mahmoodw,
rkamd and
yoichiyoshida
as code owners
TorreZuk
previously approved these changes
Jul 16, 2025
Contributor
TorreZuk
left a comment
TorreZuk
left a comment
There was a problem hiding this comment.
Need Tensile review and so will tensile PR land first and tensile_tag commit be added?
amd-mtrifuno
added a commit
that referenced
this pull request
Jul 16, 2025
- Add missing changes for gfx1151 - rocBLAS PR with gfx1151 yaml files that requires Tensile changes: #699
assistant-librarian Bot
pushed a commit
to ROCm/Tensile
that referenced
this pull request
Jul 16, 2025
Complete gfx1151 Tensile support (#696) - Add missing changes for gfx1151 - rocBLAS PR with gfx1151 yaml files that requires Tensile changes: ROCm/rocm-libraries#699
amd-mtrifuno
added a commit
that referenced
this pull request
Jul 16, 2025
- Add missing changes for gfx1151 - rocBLAS PR with gfx1151 yaml files that requires Tensile changes: #699
Contributor
Author
Tensile PR merged, I updated tensile_tag. |
…ete_gfx1151_support
TorreZuk
approved these changes
Jul 17, 2025
Contributor
|
@yoichiyoshida or @babakpst can you also review. All tests appear to pass. |
babakpst
approved these changes
Jul 17, 2025
bstefanuk
approved these changes
Jul 17, 2025
amcamd
approved these changes
Jul 17, 2025
amcamd
deleted the
import/develop/amd-mtrifuno_rocBLAS/complete_gfx1151_support
branch
assistant-librarian Bot
pushed a commit
to ROCm/rocBLAS
that referenced
this pull request
Jul 17, 2025
Add rocBLAS yaml files for gfx1151 (#699) - Add Strix Halo yaml files that are copy of Navi33 yaml files (the same changes added for Strix Point) - Need to update tensile_tag.txt after PR with Tensile changes is merged in rocm-libraries and automatically in ROCm/Tensile (ROCm/rocm-libraries#696) --------- Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
amd-mtrifuno
added a commit
that referenced
this pull request
Jul 18, 2025
- Add Strix Halo yaml files that are copy of Navi33 yaml files (the same changes added for Strix Point) - Need to update tensile_tag.txt after PR with Tensile changes is merged (#708) --------- Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
|
Did you manage to backport this into 7.0.1? |
Contributor
Author
Yes, PR (#744) has been merged into release/rocm-rel-7.0 branch. |
1 task
DDEle
added a commit
that referenced
this pull request
Apr 21, 2026
## Motivation The AITER and FA test dockers (`Dockerfile.aiter`, `Dockerfile.fa`) inherit from the `rocm/pytorch` base image. Recent updates to that base image dropped the `render` group from `/etc/group`, so every parallel test stage now fails on the test agents with: ``` docker: Error response from daemon: Unable to find group render: no matching entries in group file. ``` Jenkins resolves `--group-add render` against the **container's** `/etc/group`, not the host's, so even though the test agents have render in their `/etc/group` (GID 109), the container lookup fails. This pattern affects every recent develop build ([#673](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/673), [#674](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/674), [#686](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/686), [#688](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/688), [#699](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/699), [#708](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/708) — 6 days in a row), where AITER tests fail in seconds and the cascading failure aborts all downstream Build/FMHA/TILE_ENGINE stages. ## Technical Details Add `groupadd -f render` to both `Dockerfile.aiter` and `Dockerfile.fa`, mirroring what the main `Dockerfile` already does (`Dockerfile:96`) and what `Dockerfile.pytorch` does (`Dockerfile.pytorch:4`). The `-f` flag makes it idempotent — silently succeeds if the group already exists. This guarantees the `render` group is always present in the container, regardless of whether the base image happens to ship it. ## Test Plan Triggering AITER CI job: ## Test Result ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
aledudek
pushed a commit
that referenced
this pull request
May 20, 2026
## Motivation The AITER and FA test dockers (`Dockerfile.aiter`, `Dockerfile.fa`) inherit from the `rocm/pytorch` base image. Recent updates to that base image dropped the `render` group from `/etc/group`, so every parallel test stage now fails on the test agents with: ``` docker: Error response from daemon: Unable to find group render: no matching entries in group file. ``` Jenkins resolves `--group-add render` against the **container's** `/etc/group`, not the host's, so even though the test agents have render in their `/etc/group` (GID 109), the container lookup fails. This pattern affects every recent develop build ([#673](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/673), [#674](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/674), [#686](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/686), [#688](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/688), [#699](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/699), [#708](http://micimaster.amd.com/blue/organizations/jenkins/rocm-libraries-folder%2FComposable%20Kernel/detail/develop/708) — 6 days in a row), where AITER tests fail in seconds and the cascading failure aborts all downstream Build/FMHA/TILE_ENGINE stages. ## Technical Details Add `groupadd -f render` to both `Dockerfile.aiter` and `Dockerfile.fa`, mirroring what the main `Dockerfile` already does (`Dockerfile:96`) and what `Dockerfile.pytorch` does (`Dockerfile.pytorch:4`). The `-f` flag makes it idempotent — silently succeeds if the group already exists. This guarantees the `render` group is always present in the container, regardless of whether the base image happens to ship it. ## Test Plan Triggering AITER CI job: ## Test Result ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Strix Halo yaml files that are copy of Navi33 yaml files (the same changes added for Strix Point)
Need to update tensile_tag.txt after PR with Tensile changes is merged in rocm-libraries and automatically in ROCm/Tensile (Complete gfx1151 Tensile support #696)